fix constructor order, friend class, inconsistent function, inconsistent class/struct #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:testing
upsj
approved these changes
Nov 14, 2024
yhmtsai
force-pushed
the
clang_cl
branch
6 times, most recently
from
083b66d
to
9e53640
Compare
yhmtsai
added
1:ST:ready-for-review
|
I found the const-ness issue by lucky. I do not have an idea that any tool can help detecting this situation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #1675 , we can not use clang-cl on windows to build ginkgo (maybe only static build, not sure the shared build)
The reason is the inconsistence between the declaration and declaration of definition.
For example,
We declare
void func(int *a);, which is seen by ginkgo_core. We also use it to instantiate the function.However, we implement it like
void func(int *const a) {...}.The symbol in the library from clang-cl will use
void func(int *const a)notvoid func(int *a).core only know
void func(int *a)such that it can not find the symbol properly although theint* ashould be fit intoint* const aMore than that, I also fix the constructor order is different from the data member order, microsoft does not like the friend class without namespace not in the nearest namespace, and inconsistent class/struct.
also, add some tricks to avoid alais undeclared in the a structure which is in another tempalted structure.
It is mentioned in llvm/llvm-project#64996
we use
using .. = ..in the nested struct as workaround here